[oadp-1.4] OADP-8486: Added startup probe - #2325
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@NicholasYancey: This pull request references OADP-8486 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Please upload reports for the commit 03dafac to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## oadp-1.4 #2325 +/- ##
============================================
+ Coverage 32.15% 37.47% +5.32%
============================================
Files 30 30
Lines 4933 4998 +65
============================================
+ Hits 1586 1873 +287
+ Misses 3172 2931 -241
- Partials 175 194 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, NicholasYancey, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@NicholasYancey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Why the changes were made
Adds a StartupProbe to the CLI download server deployment on oadp-1.4, giving the container up to 60 seconds to start before liveness checks begin. This prevents premature restarts on slow-starting nodes and is required for Telco/CNF health-check certification (liveness/readiness/startup probes must be present on all deployed containers).
Also backfills the probe onto existing deployments during an operator upgrade, so already-running clusters get it automatically without manual intervention.
How to test the changes made
Run the unit tests covering the new probe and backfill logic:
On a live cluster, confirm the probe shows up on the deployment:
oc get deploy -n openshift-adp openshift-adp-oadp-cli-server \ -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'